This repository has been archived by the owner on Jun 23, 2024. It is now read-only.
Experimental support for use of expressions in custom variables #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No joy? |
theofidry
reviewed
Sep 21, 2023
|
|
||
| psysh: | ||
| variables: | ||
| foo: bar | ||
| router: "@router" | ||
| some: [thing, else] | ||
| debug: "%kernel.debug%" | ||
| doctrine: "{service('%containerId').get('doctrine')}" |
There was a problem hiding this comment.
Wouldn't @=service('%containerId').get('doctrine') be enough here?
| if (is_string($value)) { | ||
| if (strpos($value, '@') === 0) { | ||
| $value = new Reference(substr($value, 1)); | ||
| } else if (strpos($value, '{') === 0) { |
There was a problem hiding this comment.
As mentioned above I think if we are to introduce support for expressions we should we the "standard" expression? Or maybe I'm confusing with something else... Maybe OverblogGraphQLBundle YAML config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proof of concept to get a discussion started around the possibility of introducing support for expressions in custom variables. There are many different ways this could be implemented and I'm not tied to this specific implementation, but just wanted to get the convo started. @theofidry curious your thoughts on this? Has this been considered?